Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add Do not copy option to address copy modal #3949

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Feat: Add Do not copy option to address copy modal #3949

merged 4 commits into from
Jul 17, 2024

Conversation

jmealy
Copy link
Contributor

@jmealy jmealy commented Jul 15, 2024 •
edited
Loading

What it solves

Resolves #3083

How this PR fixes it

  • Add a new primary CTA button in the warning modal for copying potentially suspicious addresses.

How to test it

  • Find an untrusted or imitation transaction.
  • Use the copy address modal and see that it is shown as expected.
  • The Do not copy option should close the modal without any action.

Screenshots

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

Branch preview

✅ Deploy successful!

Website:
https://copy_warning_modal--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook:
https://copy_warning_modal--walletweb.review.5afe.dev/storybook/

@jmealy jmealy requested a review from schmanu July 15, 2024 13:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1013.23 KB (🟡 +81 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@github-actions GitHub Actions
Copy link

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
79.05% (+0% 🔼)
 11617/14696
🔴 Branches 58.68% 2855/4865
🟡 Functions 66.01% 1855/2810
🟢 Lines
80.44% (+0% 🔼)
 10475/13022

Test suite run success

1433 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from c9ca4c4

schmanu
schmanu approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thanks! This looks good :)

@francovenica
Copy link
Contributor

Checked in mobile viewport and dark mode
Copy button still works fine

LGTM

@jmealy jmealy merged commit 0493200 into dev Jul 17, 2024
14 checks passed
@jmealy jmealy deleted the copy-warning-modal branch July 17, 2024 09:58
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmanu schmanu schmanu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make "Proceed and copy" button less prominent in "Before you copy" modal
3 participants
@jmealy @francovenica @schmanu